Colanth has been a great help with some awesome code that will keep the site safer than it was. We will both automatically receive e-mails daily with the site files attached!
Colanth is an experienced PHP developer with a little extra time on his hands and has agreed to assist me in keeping the site going (Thank You!). He will help lift the burden of keeping things running around here :-)
Congratulations Colanth!
Thanks to Colanth. (and thanks to you too Wolf)
=D> =D> =D>
Thanks to the board. Being retired means that I forget everything. Having to work on the board will keep me from rusting away.
Quote from: "Colanth"Thanks to the board. Being retired means that I forget everything. Having to work on the board will keep me from rusting away.
I know the feeling......
Congrats :)
Good team so far :)
Yay.
Make it as least reliable on JS as possible, only for mobile at most, and rely on CSS and PHP as much as possible.
And for Jebus' sake, remove that eval() function.
I'm a former site hack and have already forgotten more than I ever learned. At least now the site is faster and so far no blank white screens since the server switchover.. Thanks fellers.. good show. :)
Quote from: "Sal1981"Yay.
Make it as least reliable on JS as possible, only for mobile at most, and rely on CSS and PHP as much as possible.
And for Jebus' sake, remove that eval() function.
which eval()?
So he's sort of like Gandalf then.
Quote from: "wolf39us"Quote from: "Sal1981"Yay.
Make it as least reliable on JS as possible, only for mobile at most, and rely on CSS and PHP as much as possible.
And for Jebus' sake, remove that eval() function.
which eval()?
Appears at line 72 in the HTML document of the viewtopic.php and posting.php
Only if you don't see any other way around than using eval(). I obviously don't see the php page from the server, but wouldn't it be easier to just use getElementsByTagName or somesuch to get the element id?
http://php.net/manual/en/function.eval.php (http://php.net/manual/en/function.eval.php)
Quote[center:1yw5tsrg]Caution[/center:1yw5tsrg]
The eval() language construct is very dangerous because it allows execution of arbitrary PHP code. Its use thus is discouraged. If you have carefully verified that there is no other option than to use this construct, pay special attention not to pass any user provided data into it without properly validating it beforehand.
I searched both those files.
Neither of them are sporting an eval function
Saweeeet!
It occurs in the overall_header tpl files in the cache, but not in any other files. It's in function marklist(). (Probably only generated dynamically - and that would put it in the core files.)
[Edit]
Oops, I was wrong. It's in overall_header.php too.
(//http://helpmesupergeek.com/images/Super-Geek-ContactL.gif)
Congratulations! Make us proud! (And by that I mean that you do a lot of free work and favors for us. Yeah, if you could do that, that would be great)
Quote from: "Colanth"Thanks to the board. Being retired means that I forget everything. Having to work on the board will keep me from rusting away.
Ha! Ha! You have to take responsibility for things!
Right now I'm trying to fit my head through a brick wall that has no hole yet. Some people shouldn't be allowed to write computer code.
Hmph. I know PHP and JS as well.... :-&
Oh, NOW he tells me! AFTER I fixed things.
And your name's all sparkly now, too. You code-writer you!
:rolleyes: =D> :rolleyes:
That's what they tell me, Bri. :)
Right now, I'm a head-against-the-wall-banger. I got this mod working on my local version of the forum, but something's missing when I install it on the real forum. Oh, well, that's what makes life interesting.
Quote from: "Colanth"Right now I'm trying to fit my head through a brick wall that has no hole yet. Some people shouldn't be allowed to write computer code.
Ain't that the truth. I'm a programmer, not an expert on web languages, but I've been handed some shit code at work many times.
This isn't shit code, it's easy to follow. It just doesn't work the way it's supposed to. I think someone let a little bit of magic smoke get out of it.